Skip to content

Toger5/refactor-session-manager-based-on-sticky-events #5040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 62 commits into
base: develop
Choose a base branch
from
Draft

Toger5/refactor-session-manager-based-on-sticky-events #5040

wants to merge 62 commits into from

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Oct 11, 2025 •
edited
Loading

This PR changes the responsibitiy of the SessionManager.

  • before: it was listeinging to all state event updates and called recalculate members on effected rtc sessions. This resulted in a couple of duplicated member recalculations because the session itself also listened to the same events.
  • now: The SessionManager is ONLY responsible for starting a session. So it will only listen to the events required to find out if a new sessins just started. All event listener setup is done inside the MatrixRTC session itself. This also makes the RTCSession easier to read since we do not call recalculateSessionMembers externally which cannot be seen when just looking at the MatrixRTC session.

Signed-off-by: Timo K [email protected]

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Half-Shot and others added 30 commits October 1, 2025 11:57
@Half-Shot
Implement Sticky Events MSC
bf14e37
@Half-Shot
Renames
aef07fc
@Half-Shot
lint
dc69e8b
@Half-Shot
some review work
437a37a
@Half-Shot
Update for support for 4-ples
831a87e
@Half-Shot
fix lint
bec246d
@Half-Shot
pull through method
3019576
@Half-Shot
Fix the mistake
dae2f39
@Half-Shot
More tests to appease SC
48a8e37
@Half-Shot
Merge branch 'develop' into hs/sticky-events
bf2835b
@Half-Shot
Cleaner code
79aa439
@Half-Shot
Review cleanup
7b7f74d
@Half-Shot
Refactors based on review.
ffdca00
@Half-Shot
lint
5601a0d
@Half-Shot
Merge remote-tracking branch 'origin/develop' into hs/sticky-events
ba557ed
@toger5 @Half-Shot
Add sticky event support to the js-sdk
b06d5df 
Signed-off-by: Timo K <[email protected]>
@Half-Shot
use sticky events for matrixRTC
cd2914c 
Signed-off-by: Timo K <[email protected]>
@toger5 @Half-Shot
make sticky events a non breaking change (default to state events. us…
d6c99de 
…e joinConfig to use sticky events)

Signed-off-by: Timo K <[email protected]>
@toger5 @Half-Shot
review
8dd68c0 
 - fix types (`msc4354_sticky:number` -> `msc4354_sticky?: { duration_ms: number };`)
  - add `MultiKeyMap`

Signed-off-by: Timo K <[email protected]>
@Half-Shot
Refactor all of this away to it's own accumulator and class.
adcb2bb
@Half-Shot
Add tests
510c2c3
@Half-Shot
tidyup
ab310df
@Half-Shot
more test cleaning
caf916a
@Half-Shot
lint
953b7d7
@Half-Shot
Updates and tests
d376e94
@Half-Shot
fix filter
0d38f14
@Half-Shot
fix filter with lint
207bab8
@Half-Shot
Add timer tests
0b1fae5
@Half-Shot
Add tests for MatrixRTCSessionManager
791b119
@Half-Shot
Listen for sticky events on MatrixRTCSessionManager
488d3ae
Half-Shot and others added 28 commits October 7, 2025 11:31
@Half-Shot
Add logging in areas
e5027c7
@Half-Shot
more debugging
3e8115d
@Half-Shot
much more logging
f8f2c6d
@Half-Shot
remove more logging
32f9343
@Half-Shot
Finish supporting new MSC
d4b2252
@Half-Shot
a line
8d449a6
@Half-Shot
reconnect the bits to RTC
4d13031
@Half-Shot
fixup more bits
af8c329
@Half-Shot
fixup testrs
42cdbf7
@Half-Shot
Ensure consistent order
6bac0ad
@Half-Shot
lint
673b53b
@Half-Shot
fix log line
54f4539
@Half-Shot
remove extra bit of code
71d3e73
@Half-Shot
revert changes to room-sticky-events.ts
946c20a
@Half-Shot
fixup mocks again
9283ec5
@Half-Shot
lint
8b9bb74
@Half-Shot
fix
0e7ba51
@Half-Shot
cleanup
06fd1bf
@Half-Shot
fix paths
08b8675
@Half-Shot
tweak test
b4aed2c
@toger5
Merge branch 'develop' into toger5/sticky-events
f0bde5f 
Signed-off-by: Timo K <[email protected]>
@Half-Shot
fixup
b6a782b
@Half-Shot
Add more tests for coverage
2ce019a
@toger5
Merge branch 'develop' into toger5/sticky-events
8f157da 
Signed-off-by: Timo K <[email protected]>
@toger5
Small improvements
d70e4f7 
Signed-off-by: Timo K <[email protected]>
@toger5
review
2042f75 
Signed-off-by: Timo K <[email protected]>
@toger5
Make membership manager only be responsible for sessions starts
0dbc652 
Signed-off-by: Timo K <[email protected]>
@toger5
remove onRTCSessionMemberUpdate
846cfbd 
Signed-off-by: Timo K <[email protected]>
Base automatically changed from toger5/sticky-events to develop October 23, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@toger5 @Half-Shot